Skip to content

Send test post to verify that the automation works - #8

Merged
joyeecheung merged 1 commit into
mainfrom
verify-post
Dec 2, 2024
Merged

Send test post to verify that the automation works#8
joyeecheung merged 1 commit into
mainfrom
verify-post

Conversation

@joyeecheung

@joyeecheung joyeecheung commented Dec 1, 2024

Copy link
Copy Markdown
Member

Reopened from #5 from a branch in this repository, because turns out secrets are not available to workflows started from forks (duh). Will do a bit of follow-up to split the validation into full validation (validates bluesky URL references which requires secrets) + local validation (just that the JSON looks right, without requiring secrets) as mentioned in #5 (comment) but for now creating PRs from branches in this repo should be fine.

@joyeecheung

joyeecheung commented Dec 1, 2024

Copy link
Copy Markdown
Member Author

cc @nodejs/tsc (sorry for the noise, I guess there's trial and error for everything for the first time! But the validation workflow looks happy enough ;))

@anonrig

anonrig commented Dec 1, 2024

Copy link
Copy Markdown
Member

🚀

@mcollina mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@joyeecheung
joyeecheung merged commit 47aa614 into main Dec 2, 2024
github-actions Bot added a commit that referenced this pull request Dec 2, 2024
@joyeecheung

Copy link
Copy Markdown
Member Author

For posterity, it works: https://bsky.app/profile/nodejs.org/post/3lcd5ct56w42m

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants